feat: push_str capacity exceeds error message#2
Merged
tindzk merged 2 commits intotindzk:mainfrom Nov 20, 2025
Merged
Conversation
Owner
|
Thanks for the contribution! Could you please add a test for this change in |
Owner
|
Thanks! I released v0.1.2 with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, great work on the library! The source code is very clean and nicely structured :)
I improved
ExceedsCapacityerror message clarity. I made a small change to improve theExceedsCapacityerror message, which was a bit confusing in its current form.In current state:
Error message: String length (0) exceeds capacity (7)
This may be misleading because it shows the current string length (0) instead of the total length that the operation should result in (11). (In my opinion)
After this change
Error message: String length (11) exceeds capacity (7)
The error now displays the total resulting length (current length + new string length) instead of just the initial value.